Re: [PATCH v5] dt-bindings: usb: Add new compatible string for AM64 SoC

From: Rob Herring
Date: Mon Dec 14 2020 - 15:49:06 EST


On Mon, Dec 14, 2020 at 07:31:09PM +0530, Aswath Govindraju wrote:
> Add compatible string in j721e-usb binding file as the same USB subsystem
> is present in AM64.
>
> Signed-off-by: Aswath Govindraju <a-govindraju@xxxxxx>
> ---
>
> Changes since v4:
> - used oneOf instead of enum, as the schema has to convey that the strings
> ti,j721e-usb and ti,am64-usb can be used combined or seperately in the
> DT nodes.
>
> Changes since v3:
> - used enum instead of anyOf.
>
> Changes since v2:
> - added changes done over the versions.
>
> Changes since v1:
> - replaced the '\t' at the beginning of the lines with spaces as it was
> causing the dt_binding_check to fail.
>
> Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
> index 388245b91a55..21e51ceca293 100644
> --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
> +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
> @@ -11,8 +11,12 @@ maintainers:
>
> properties:
> compatible:
> - items:
> + oneOf:
> - const: ti,j721e-usb
> + - const: ti,am64-usb
> + - items:
> + - ti,j721e-usb
> + - ti,am64-usb

^

const needed before the strings

>
> reg:
> description: module registers
> --
> 2.17.1
>