Re: 8353d30e747f ("drm/amd/display: disable stream if pixel clock changed with link active")

From: Alex Deucher
Date: Mon Dec 14 2020 - 16:51:02 EST


On Fri, Dec 11, 2020 at 11:49 AM Borislav Petkov <bp@xxxxxxxxx> wrote:
>
> Hi,
>
> patch in $Subject breaks booting on a laptop here, GPU details are
> below. The machine stops booting right when it attempts to switch modes
> during boot, to a higher mode than the default VGA one. Machine doesn't
> ping and is otherwise unresponsive so that a hard reset is the only
> thing that helps.
>
> Reverting that patch ontop of -rc7 fixes it and the machine boots just fine.

+ a few more display folks

This patch looks like a correctness fix, but not critical. Unless
anyone has a proper fix handy, I'll just revert it for now and we can
revisit it properly.

Alex


>
> Thx.
>
> [ 1.628086] ata1.00: supports DRM functions and may not be fully accessible
> [ 1.632050] ata1.00: supports DRM functions and may not be fully accessible
> [ 1.895818] [drm] amdgpu kernel modesetting enabled.
> [ 1.897628] [drm] initializing kernel modesetting (CARRIZO 0x1002:0x9874 0x103C:0x807E 0xC4).
> [ 1.898256] [drm] register mmio base: 0xD0C00000
> [ 1.898422] [drm] register mmio size: 262144
> [ 1.898583] [drm] add ip block number 0 <vi_common>
> [ 1.898759] [drm] add ip block number 1 <gmc_v8_0>
> [ 1.898931] [drm] add ip block number 2 <cz_ih>
> [ 1.899082] [drm] add ip block number 3 <gfx_v8_0>
> [ 1.899241] [drm] add ip block number 4 <sdma_v3_0>
> [ 1.899439] [drm] add ip block number 5 <powerplay>
> [ 1.899573] [drm] add ip block number 6 <dm>
> [ 1.899693] [drm] add ip block number 7 <uvd_v6_0>
> [ 1.899827] [drm] add ip block number 8 <vce_v3_0>
> [ 1.911458] [drm] BIOS signature incorrect 5b 7
> [ 1.912551] [drm] UVD is enabled in physical mode
> [ 1.912707] [drm] VCE enabled in physical mode
> [ 1.912921] [drm] vm size is 64 GB, 2 levels, block size is 10-bit, fragment size is 9-bit
> [ 1.913837] [drm] Detected VRAM RAM=512M, BAR=512M
> [ 1.913998] [drm] RAM width 128bits UNKNOWN
> [ 1.915149] [drm] amdgpu: 512M of VRAM memory ready
> [ 1.915306] [drm] amdgpu: 3072M of GTT memory ready.
> [ 1.915468] [drm] GART: num cpu pages 262144, num gpu pages 262144
> [ 1.916139] [drm] PCIE GART of 1024M enabled (table at 0x000000F400900000).
> [ 1.918733] [drm] Found UVD firmware Version: 1.91 Family ID: 11
> [ 1.918950] [drm] UVD ENC is disabled
> [ 1.919680] [drm] Found VCE firmware Version: 52.4 Binary ID: 3
> [ 1.925963] [drm] DM_PPLIB: values for Engine clock
> [ 1.926106] [drm] DM_PPLIB: 300000
> [ 1.926205] [drm] DM_PPLIB: 360000
> [ 1.926304] [drm] DM_PPLIB: 423530
> [ 1.926404] [drm] DM_PPLIB: 514290
> [ 1.926516] [drm] DM_PPLIB: 626090
> [ 1.926629] [drm] DM_PPLIB: 720000
> [ 1.926743] [drm] DM_PPLIB: Validation clocks:
> [ 1.926952] [drm] DM_PPLIB: engine_max_clock: 72000
> [ 1.927117] [drm] DM_PPLIB: memory_max_clock: 80000
> [ 1.927281] [drm] DM_PPLIB: level : 8
> [ 1.927435] [drm] DM_PPLIB: values for Display clock
> [ 1.927594] [drm] DM_PPLIB: 300000
> [ 1.927708] [drm] DM_PPLIB: 400000
> [ 1.927822] [drm] DM_PPLIB: 496560
> [ 1.927936] [drm] DM_PPLIB: 626090
> [ 1.928048] [drm] DM_PPLIB: 685720
> [ 1.928161] [drm] DM_PPLIB: 757900
> [ 1.928275] [drm] DM_PPLIB: Validation clocks:
> [ 1.928419] [drm] DM_PPLIB: engine_max_clock: 72000
> [ 1.928584] [drm] DM_PPLIB: memory_max_clock: 80000
> [ 1.928748] [drm] DM_PPLIB: level : 8
> [ 1.928901] [drm] DM_PPLIB: values for Memory clock
> [ 1.929058] [drm] DM_PPLIB: 333000
> [ 1.929172] [drm] DM_PPLIB: 800000
> [ 1.929403] [drm] DM_PPLIB: Validation clocks:
> [ 1.929549] [drm] DM_PPLIB: engine_max_clock: 72000
> [ 1.929716] [drm] DM_PPLIB: memory_max_clock: 80000
> [ 1.929919] [drm] DM_PPLIB: level : 8
> [ 1.930148] [drm] Display Core initialized with v3.2.104!
> [ 2.003938] [drm] UVD initialized successfully.
> [ 2.204023] [drm] VCE initialized successfully.
> [ 2.206228] [drm] fb mappable at 0xA0EE4000
> [ 2.206375] [drm] vram apper at 0xA0000000
> [ 2.206514] [drm] size 14745600
> [ 2.206654] [drm] fb depth is 24
> [ 2.206760] [drm] pitch is 10240
> [ 2.207123] fbcon: amdgpudrmfb (fb0) is primary device
> [ 2.301263] amdgpu 0000:00:01.0: [drm] fb0: amdgpudrmfb frame buffer device
> [ 2.320735] [drm] Initialized amdgpu 3.40.0 20150101 for 0000:00:01.0 on minor 0
>
>
> --
> Regards/Gruss,
> Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx