Re: [PATCH v3 06/15] dt-bindings: media: sun6i-a31-csi: Add MIPI CSI-2 input port
From: Rob Herring
Date: Mon Dec 14 2020 - 18:13:40 EST
On Fri, 11 Dec 2020 16:56:59 +0100, Paul Kocialkowski wrote:
> The A31 CSI controller supports two distinct input interfaces:
> parallel and an external MIPI CSI-2 bridge. The parallel interface
> is often connected to a set of hardware pins while the MIPI CSI-2
> bridge is an internal FIFO-ish link. As a result, these two inputs
> are distinguished as two different ports.
>
> Note that only one of the two may be present on a controller instance.
> For example, the V3s has one controller dedicated to MIPI-CSI2 and one
> dedicated to parallel.
>
> Update the binding with an explicit ports node that holds two distinct
> port nodes: one for parallel input and one for MIPI CSI-2.
>
> This is backward-compatible with the single-port approach that was
> previously taken for representing the parallel interface port, which
> stays enumerated as fwnode port 0.
>
> Note that additional ports may be added in the future, especially to
> support feeding the CSI controller's output to the ISP.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@xxxxxxxxxxx>
> ---
> .../media/allwinner,sun6i-a31-csi.yaml | 88 ++++++++++++++++---
> 1 file changed, 75 insertions(+), 13 deletions(-)
>
Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
Though, it may need updating to use video-interfaces and graph
schemas[1] depending what lands first.
[1] https://lore.kernel.org/linux-devicetree/20201210211625.3070388-4-robh@xxxxxxxxxx/