Re: [PATCH net-next v2] net: dsa: mv88e6xxx: don't set non-existing learn2all bit for 6220/6250
From: Jakub Kicinski
Date: Mon Dec 14 2020 - 21:17:42 EST
On Thu, 10 Dec 2020 12:06:44 +0100 Rasmus Villemoes wrote:
> The 6220 and 6250 switches do not have a learn2all bit in global1, ATU
> control register; bit 3 is reserverd.
>
> On the switches that do have that bit, it is used to control whether
> learning frames are sent out the ports that have the message_port bit
> set. So rather than adding yet another chip method, use the existence
> of the ->port_setup_message_port method as a proxy for determining
> whether the learn2all bit exists (and should be set).
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@xxxxxxxxx>
Applied.