Re: [PATCH 2/2] EDAC/amd64: Merge error injection sysfs facilities

[Borislav Petkov]

On Tue, Dec 15, 2020 at 10:11:20AM -0600, Yazen Ghannam wrote:
> Can we say "Opterons (Family 10h to Family 15h)"? It may also apply to
> Family 16h, but I don't know if they were branded as Opterons.
> 
> The injection code in this module doesn't apply to Family 17h and later.
> 
> Also, Family 17h and later doesn't allow the OS direct access to the error
> injection registers. They're locked down by security policy, etc.

Yeah, figured as much after I started getting all 0s while poking at
them with setpci...

Ok, I'll fix that ontop - this patch should be only code movement and
trivial cleanups, functionality changes ontop.

> Related to the comment above, can this be changed to the following?
> 
> 	if (pvt->fam < 0x10 || pvt->fam >= 0x17)

Right.

> Everything else looks good to me.
> 
> Reviewed-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette