Re: [PATCH] regulator: pf8x00: Use specific compatible strings for devices

From: Jagan Teki
Date: Tue Dec 15 2020 - 15:22:09 EST


On Tue, Dec 15, 2020 at 6:50 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> The pf8x00 driver supports three devices, the DT compatible strings
> and I2C IDs should enumerate these specifically rather than using a
> wildcard so that we don't collide with anything incompatible in the
> same ID range in the future and so that we can handle any software
> visible differences between the variants we find.

Thanks for the patch.

>
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
> ---
> .../bindings/regulator/nxp,pf8x00-regulator.yaml | 6 ++++--
> drivers/regulator/pf8x00-regulator.c | 8 ++++++--

I think the bindings patch would be separate? otherwise,

Reviewed-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>