Re: [PATCH v3 12/12] mfd: bd9571mwv: Add support for BD9574MWF

[Vaittinen, Matti]

On Wed, 2020-12-16 at 09:02 +0000, Lee Jones wrote:
> On Wed, 16 Dec 2020, Vaittinen, Matti wrote:
> 
> > On Wed, 2020-12-16 at 16:37 +0900, Yoshihiro Shimoda wrote:
> > > From: Khiem Nguyen <khiem.nguyen.xt@xxxxxxxxxxx>
> > > 
> > > The new PMIC BD9574MWF inherits features from BD9571MWV.
> > > Add the support of new PMIC to existing bd9571mwv driver.
> > > 
> > > Signed-off-by: Khiem Nguyen <khiem.nguyen.xt@xxxxxxxxxxx>
> > > [shimoda: rebase and refactor]
> > > Signed-off-by: Yoshihiro Shimoda <
> > > yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > 
> > Reviewed-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>
> > 
> > > ---
> > >  drivers/mfd/bd9571mwv.c       | 86
> > > ++++++++++++++++++++++++++++++++++++++++++-
> > >  include/linux/mfd/bd9571mwv.h | 18 +++++++--
> > >  2 files changed, 99 insertions(+), 5 deletions(-)
> 
> ... and please snip long replies.
> 
> Scrolling down past lots of un-reviewed code and/or past the end of
> the last review comment is a waste of people's time.  Thanks.
> 
Hm. Right. I thought that leaving whole patch there when just adding
ack or reviewed-by gives full information as to which exact patch
version was reviewed. But I admit scrolling can be annoying - besides,
the send/receive time in quote can probably be used to track the excat
version which was reviewed. So point taken. Thanks.

Best Regards
    Matti