Re: [PATCH][next] netfilter: nftables: fix incorrect increment of loop counter

From: Pablo Neira Ayuso
Date: Wed Dec 16 2020 - 05:03:37 EST


On Mon, Dec 14, 2020 at 11:40:15PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The intention of the err_expr cleanup path is to iterate over the
> allocated expr_array objects and free them, starting from i - 1 and
> working down to the start of the array. Currently the loop counter
> is being incremented instead of decremented and also the index i is
> being used instead of k, repeatedly destroying the same expr_array
> element. Fix this by decrementing k and using k as the index into
> expr_array.

Applied to nf.git, thanks.