[PATCH][next] NFSv4.2: fix error return on memory allocation failure

From: Colin King
Date: Wed Dec 16 2020 - 07:26:57 EST


From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Currently when an alloc_page fails the error return is not set in
variable err and a garbage initialized value is returned. Fix this
by setting err to -ENOMEM before taking the error return path.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: a1f26739ccdc ("NFSv4.2: improve page handling for GETXATTR")
Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
---
fs/nfs/nfs42proc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/fs/nfs/nfs42proc.c b/fs/nfs/nfs42proc.c
index b9836e2ce4a2..f3fd935620fc 100644
--- a/fs/nfs/nfs42proc.c
+++ b/fs/nfs/nfs42proc.c
@@ -1301,6 +1301,7 @@ ssize_t nfs42_proc_getxattr(struct inode *inode, const char *name,
pages[i] = alloc_page(GFP_KERNEL);
if (!pages[i]) {
np = i + 1;
+ err = -ENOMEM;
goto out;
}
}
--
2.29.2