Re: [PATCH v4 1/3] scsi: ufs: Protect some contexts from unexpected clock scaling

From: Bean Huo
Date: Wed Dec 16 2020 - 08:32:19 EST


On Sun, 2020-12-13 at 08:31 -0800, Can Guo wrote:
> In contexts like suspend, shutdown and error handling, we need to
> suspend
> devfreq to make sure these contexts won't be disturbed by clock
> scaling.
> However, suspending devfreq is not enough since users can still
> trigger a
> clock scaling by manipulating the sysfs node clkscale_enable and
> devfreq
> sysfs nodes like min/max_freq and governor. Add one more flag in
> struct
> clk_scaling such that these contexts can prevent clock scaling from
> being
> invoked through above sysfs nodes.
>
> Signed-off-by: Can Guo <cang@xxxxxxxxxxxxxx>
looks good to me.

Reviewed-by: Bean Huo <beanhuo@xxxxxxxxxx>