Re: [PATCH v1 7/8] usb: host: ehci-tegra: Remove the driver
From: Dmitry Osipenko
Date: Wed Dec 16 2020 - 12:28:53 EST
16.12.2020 20:22, Alan Stern пишет:
> On Wed, Dec 16, 2020 at 08:09:51PM +0300, Dmitry Osipenko wrote:
>> 16.12.2020 19:45, Alan Stern пишет:
>>> On Tue, Dec 15, 2020 at 11:21:12PM +0300, Dmitry Osipenko wrote:
>>>> The ChipIdea driver now provides USB2 host mode support for NVIDIA Tegra
>>>> SoCs. The ehci-tegra driver is obsolete now, remove it.
>>>>
>>>> Tested-by: Matt Merhar <mattmerhar@xxxxxxxxxxxxxx>
>>>> Tested-by: Nicolas Chauvet <kwizart@xxxxxxxxx>
>>>> Tested-by: Peter Geis <pgwipeout@xxxxxxxxx>
>>>> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
>>>> ---
>>>> drivers/usb/host/Kconfig | 9 -
>>>> drivers/usb/host/Makefile | 1 -
>>>> drivers/usb/host/ehci-tegra.c | 604 ----------------------------------
>>>> 3 files changed, 614 deletions(-)
>>>> delete mode 100644 drivers/usb/host/ehci-tegra.c
>>>>
>>>> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
>>>> index 31e59309da1f..9c9e6ff9c43a 100644
>>>> --- a/drivers/usb/host/Kconfig
>>>> +++ b/drivers/usb/host/Kconfig
>>>> @@ -266,15 +266,6 @@ config USB_EHCI_HCD_AT91
>>>> Enables support for the on-chip EHCI controller on
>>>> Atmel chips.
>>>>
>>>> -config USB_EHCI_TEGRA
>>>> - tristate "NVIDIA Tegra HCD support"
>>>> - depends on ARCH_TEGRA
>>>> - select USB_EHCI_ROOT_HUB_TT
>>>> - select USB_TEGRA_PHY
>>>> - help
>>>> - This driver enables support for the internal USB Host Controllers
>>>> - found in NVIDIA Tegra SoCs. The controllers are EHCI compliant.
>>>
>>> For people upgrading from earlier kernel versions, do you think it
>>> would help to add a pointer here telling them which Kconfig option
>>> they need to enable now in order to get this functionality?
>>
>> Could you please clarify what do you mean by the "pointer"?
>
> See the entries for USB_CNS3XXX_EHCI, USB_OCTEON_EHCI,
> USB_OHCI_HCD_OMAP3, and USB_OHCI_SH in that Kconfig file for examples.
I'll point the deprecated USB_EHCI_TEGRA to the CI driver in a v2, thanks.