Re: [PATCH v4] kcov, usbip: collect coverage from vhci_rx_loop

From: Shuah Khan
Date: Wed Dec 16 2020 - 19:02:52 EST


On 11/23/20 4:50 PM, Andrey Konovalov wrote:
From: Nazime Hande Harputluoglu <handeharputlu@xxxxxxxxxx>

Add kcov_remote_start()/kcov_remote_stop() annotations to the
vhci_rx_loop() function, which is responsible for parsing USB/IP packets
coming into USB/IP client.

Since vhci_rx_loop() threads are spawned per vhci_hcd device instance, the
common kcov handle is used for kcov_remote_start()/stop() annotations
(see Documentation/dev-tools/kcov.rst for details). As the result kcov
can now be used to collect coverage from vhci_rx_loop() threads.

Signed-off-by: Nazime Hande Harputluoglu <handeharputlu@xxxxxxxxxx>
Co-developed-by: Andrey Konovalov <andreyknvl@xxxxxxxxxx>
Signed-off-by: Andrey Konovalov <andreyknvl@xxxxxxxxxx>
---

Changes in v4:
- Add USB/IP specific wrappers around kcov functions to avoid having a lot
of ifdef CONFIG_KCOV in the USB/IP code.


Looks good to me. Sorry for the delay on this. It just got lost in my Inbox.

Acked-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>

thanks,
-- Shuah