Re: [MPTCP][PATCH net-next] mptcp: clear use_ack and use_map when dropping other suboptions

From: Jakub Kicinski
Date: Wed Dec 16 2020 - 19:26:36 EST


On Tue, 15 Dec 2020 16:11:52 -0800 (PST) Mat Martineau wrote:
> On Tue, 15 Dec 2020, Geliang Tang wrote:
>
> > This patch cleared use_ack and use_map when dropping other suboptions to
> > fix the following syzkaller BUG:

> > Reported-by: Christoph Paasch <cpaasch@xxxxxxxxx>
> > Fixes: 84dfe3677a6f (mptcp: send out dedicated ADD_ADDR packet)
> > Signed-off-by: Geliang Tang <geliangtang@xxxxxxxxx>
> > ---
> > net/mptcp/options.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
>
> David or Jakub, this patch is intended for the -net tree (not net-next as
> labeled in the subject line). If you can apply it to -net, that's great,
> otherwise it can be resubmitted as [PATCH net].
>
> In any case, the content is good:

Should matter all that much other than for build testing.

> Reviewed-by: Mat Martineau <mathew.j.martineau@xxxxxxxxxxxxxxx>

Applied, thanks!