Re: [PATCH wireless -next] rtw88: Delete useless kfree code

From: Pkshih
Date: Wed Dec 16 2020 - 19:56:29 EST


On Wed, 2020-12-16 at 13:04 +0000, Zheng Yongjun wrote:
> The parameter of kfree function is NULL, so kfree code is useless, delete it.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@xxxxxxxxxx>

Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>

> ---
>  drivers/net/wireless/realtek/rtw88/main.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/main.c
> b/drivers/net/wireless/realtek/rtw88/main.c
> index 565efd880624..15568cd670a3 100644
> --- a/drivers/net/wireless/realtek/rtw88/main.c
> +++ b/drivers/net/wireless/realtek/rtw88/main.c
> @@ -1249,7 +1249,6 @@ static void rtw_set_supported_band(struct ieee80211_hw
> *hw,
>  
>  err_out:
>   rtw_err(rtwdev, "failed to set supported band\n");
> - kfree(sband);
>  }
>  
>  static void rtw_unset_supported_band(struct ieee80211_hw *hw,