Re: [PATCH] hwmon: SENSORS_SBTSI should depend on X86

From: Geert Uytterhoeven
Date: Thu Dec 17 2020 - 03:08:07 EST


Hi Kun, Günter,

On Wed, Dec 16, 2020 at 9:17 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> On Wed, Dec 16, 2020 at 09:27:28AM -0800, Kun Yi wrote:
> > On Wed, Dec 16, 2020 at 8:31 AM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> > >
> > > On Wed, Dec 16, 2020 at 02:46:41PM +0100, Geert Uytterhoeven wrote:
> > > > The AMD SB Temperature Sensor Interface (SB-TSI) is only present on AMD
> > > > X86 SoCs. Hence add a dependency on X86, to prevent asking the user
> > > > about this driver when configuring a kernel without AMD X86 platform
> > > > support.
> >
> > Sorry, I think there is some confusion. AMD SoC is a 'remote sensor',
> > or the client, whereas the device using the SB-TSI hwmon driver is the
> > master.
> > In industry, a typical scenario is ARM-based Board Management
> > Controllers (BMCs) using SB-TSI to monitor the host CPU temperature.

Thanks for the explanation!

> Ah, good point. I'll drop this patch.

Agreed.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds