Re: [RFC PATCH v2 4/6] mfd: add BD71827 header
From: Vaittinen, Matti
Date: Thu Dec 17 2020 - 04:41:21 EST
On Wed, 2020-12-16 at 08:53 +0000, Lee Jones wrote:
> On Fri, 04 Dec 2020, Matti Vaittinen wrote:
>
> > Add BD71827 driver header. For a record - Header is originally
> > based on work authored by Cong Pham although not much of original
> > work is left now.
> >
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>
> > ---
> > This patch was not in v1. This brings in some charger registers
> > for the BD71827 charger which is in following patches.
> >
> > include/linux/mfd/rohm-bd71827.h | 295
> > +++++++++++++++++++++++++++++++
> > 1 file changed, 295 insertions(+)
> > create mode 100644 include/linux/mfd/rohm-bd71827.h
> >
> > diff --git a/include/linux/mfd/rohm-bd71827.h
> > b/include/linux/mfd/rohm-bd71827.h
> > new file mode 100644
> > index 000000000000..0f5a343b10ae
> > --- /dev/null
> > +++ b/include/linux/mfd/rohm-bd71827.h
> > @@ -0,0 +1,295 @@
> > +/* SPDX-License-Identifier: GPL-2.0-or-later */
> > +/*
> > + * Copyright 2016
>
> Out of date.
...
Thanks for the review Lee! It was unexpected as I didn't add you to CC.
Reason for skipping you is that this was very initial RFC patch set -
intended to collect opinions of adding some fuel-gauge logic in power-
supply. I will for sure clean up the findings (and possibly some other
issues) when I proceed with these charger drivers - and at that point I
will ask for a re-review & add you in CC. But I just wanted to point
out that as the fate/format of this driver depends on how the RFC is
seen by Sebastian & others so getting back to this may take some
time...
BTW - you have nice mail-filters as you caught these pathces, you pick
every mail with MFD in subject(?)
Best Regards
Matti
--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland
SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
"non cogito me" dixit Rene Descarte, deinde evanescavit
(Thanks for the translation Simon)