Re: [PATCH] Input: gtco - remove driver

From: Jiri Kosina
Date: Thu Dec 17 2020 - 06:23:02 EST


On Sat, 5 Dec 2020, Dmitry Torokhov wrote:

> The driver has its own HID descriptor parsing code, that had and still
> has several issues discovered by syzbot and other tools. Ideally we
> should move the driver over to the HID subsystem, so that it uses proven
> parsing code. However the devices in question are EOL, and GTCO is not
> willing to extend resources for that, so let's simply remove the driver.

Acked-by: Jiri Kosina <jkosina@xxxxxxx>

>
> Note that our HID support has greatly improved over the last 10 years,
> we may also consider reverting 6f8d9e26e7de ("hid-core.c: Adds all GTCO
> CalComp Digitizers and InterWrite School Products to blacklist") and see
> if GTCO devices actually work with normal HID drivers.

Sounds like a good plan to me. Perhaps you can do that in a series
together, and stage that for 5.12?

Thanks,

--
Jiri Kosina
SUSE Labs