Re: [PATCH V3.1] entry: Pass irqentry_state_t by reference
From: Thomas Gleixner
Date: Thu Dec 17 2020 - 11:59:13 EST
On Mon, Nov 23 2020 at 22:09, ira weiny wrote:
> From: Ira Weiny <ira.weiny@xxxxxxxxx>
>
> Currently struct irqentry_state_t only contains a single bool value
> which makes passing it by value is reasonable. However, future patches
> add information to this struct. This includes the PKRS thread state,
> included in this series, as well as information to store kmap reference
> tracking and PKS global state outside this series. In total, we
> anticipate 2 new 32 bit fields and an integer field to be added to the
> struct beyond the existing bool value.
Well yes, but why can't you provide at least in the comment section
below the '---' a pointer to the latest version of this reference muck
and PKS global state if you can't explain at least the concept of the
two things here?
It's one thing that you anticipate something but a different thing
whether it's the right thing to do.
Thanks,
tglx