RE: [EXT] Re: [PATCH net] net: mvpp2: Add TCAM entry to drop flow control pause frames

From: Stefan Chulski
Date: Thu Dec 17 2020 - 13:11:52 EST


> Quoting stefanc@xxxxxxxxxxx (2020-12-17 18:45:06)
> > From: Stefan Chulski <stefanc@xxxxxxxxxxx>
> >
> > Issue:
> > Flow control frame used to pause GoP(MAC) was delivered to the CPU and
> > created a load on the CPU. Since XOFF/XON frames are used only by MAC,
> > these frames should be dropped inside MAC.
> >
> > Fix:
> > According to 802.3-2012 - IEEE Standard for Ethernet pause frame has
> > unique destination MAC address 01-80-C2-00-00-01.
> > Add TCAM parser entry to track and drop pause frames by destination MAC.
> >
> > Fixes: db9d7d36eecc ("net: mvpp2: Split the PPv2 driver to a dedicated
> > directory")
>
> Same here, you should go further in the git history.
>
> Also, was that introduced when the TCAM support landed in (overriding its
> default configuration?)? Or is that the behaviour since the beginning? I'm
> asking because while this could very be a fix, it could also fall in the
> improvements category.

I believe this behavior since the beginning of the driver.
I would repost this with fixes tag with patch that introduced this driver.

Regards.