Re: [PATCH v9 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

[Jakub Kicinski]

On Thu, 17 Dec 2020 12:53:30 +0100 Łukasz Stelmach wrote:
> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be
> connected to a CPU with a 8/16-bit bus or with an SPI. This driver
> supports SPI connection.
> 
> The driver has been ported from the vendor kernel for ARTIK5[2]
> boards. Several changes were made to adapt it to the current kernel
> which include:
> 
> + updated DT configuration,
> + clock configuration moved to DT,
> + new timer, ethtool and gpio APIs,
> + dev_* instead of pr_* and custom printk() wrappers,
> + removed awkward vendor power managemtn.
> + introduced ethtool tunable to control SPI compression
> 
> [1] https://www.asix.com.tw/products.php?op=pItemdetail&PItemID=104;65;86&PLine=65
> [2] https://git.tizen.org/cgit/profile/common/platform/kernel/linux-3.10-artik/
> 
> The other ax88796 driver is for NE2000 compatible AX88796L chip. These
> chips are not compatible. Hence, two separate drivers are required.
> 
> Signed-off-by: Łukasz Stelmach <l.stelmach@xxxxxxxxxxx>
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

drivers/net/ethernet/asix/ax88796c_main.c: In function ‘ax88796c_tx_fixup’:
drivers/net/ethernet/asix/ax88796c_main.c:248:6: warning: variable ‘tol_len’ set but not used [-Wunused-but-set-variable]
  248 |  u16 tol_len, pkt_len;
      |      ^~~~~~~