Re: [PATCH] cma_heap: fix implicit function declaration

From: John Stultz
Date: Thu Dec 17 2020 - 14:42:18 EST


On Thu, Dec 17, 2020 at 4:31 AM <siyanteng01@xxxxxxxxx> wrote:
>
> From: siyanteng <siyanteng01@xxxxxxxxx>
>
> When building cma_heap the following error shows up:
>
> drivers/dma-buf/heaps/cma_heap.c:195:10: error: implicit declaration of function 'vmap'; did you mean 'kmap'? [-Werror=implicit-function-declaration]
> 195 | vaddr = vmap(buffer->pages, buffer->pagecount, VM_MAP, PAGE_KERNEL);
> | ^~~~
> | kmap
>
> Use this include: linux-next/include/linux/vmalloc.h
>
> Signed-off-by: siyanteng <siyanteng01@xxxxxxxxx>

Thanks for submitting this! My apologies for the trouble!

We already have a similar patch queued here:
https://cgit.freedesktop.org/drm/drm-misc/commit/?h=drm-misc-next-fixes&id=8075c3005e4b1efa12dbbf6e84bc412a713de92c
so hopefully that will land upstream soon.

thanks again!
-john