Re: [PATCH V2] scsi: ufs-debugfs: Add error counters

[Bean Huo]

On Thu, 2020-12-17 at 11:49 +0200, Adrian Hunter wrote:
> > 
> > The purpose of patch is acceptable, but I don't know why you choose
> > using ufshcd_core_* here. 
> 
> Do you mean you would like a different function name?  'ufshcd_init'
> is used
> already.  The module is called ufshcd-core, so ufshcd_core_* seems
> appropriate.
> 
> > Also. I don't know if module_init()  is a proper way here.
> 
> Can you be more specific?  It is normal to do module initialization
> in
> module_init().

Hi Adrian
My concern that ufs_debugfs_init() is called in module_init(), but your
another debugfs initialization function ufs_debugfs_hba_init(hba)
called in the UFS host probe path. 

If these two (module_init() and module_platform_driver())
initializaiton sequence always as your expectation: ufs_debugfs_init()-
->ufs_debugfs_hba_init(), that is fine, otherwise, it is better just
group them, make it simpler.


Thanks,
Bean