Re: [PATCH v2 3/7] regulator: dt-bindings: pf8x00: fix nxp,phase-shift doc

From: Rob Herring
Date: Thu Dec 17 2020 - 18:51:51 EST


On Wed, Dec 16, 2020 at 12:56:35AM +0100, Adrien Grassein wrote:
> nxp,phase-shift is an enum so use enum format to describe it.
> Minimum and maximum values are also wrong.
>
> Signed-off-by: Adrien Grassein <adrien.grassein@xxxxxxxxx>
> ---
> .../bindings/regulator/nxp,pf8x00-regulator.yaml | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml
> index 913532d0532e..1da724c6e2ba 100644
> --- a/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml
> @@ -60,21 +60,13 @@ properties:
>
> nxp,phase-shift:
> $ref: "/schemas/types.yaml#/definitions/uint32"
> - minimum: 45
> - maximum: 0
> + minimum: 0
> + maximum: 315

You can drop this. It's redundant with the enum.

> + default: 0
> + enum: [ 0, 45, 90, 135, 180, 225, 270, 315 ]
> description:
> BUCK regulators phase shift control in degrees.
>
> - Listed phase shift control values in degrees are,
> - 45
> - 90
> - 135
> - 180
> - 225
> - 270
> - 315
> - 0 (default)
> -
> unevaluatedProperties: false
>
> "^vsnvs$":
> --
> 2.20.1
>