Re: [PATCH] add pin memory method for checkout add restore

From: Randy Dunlap
Date: Fri Dec 18 2020 - 12:00:25 EST


Hi,

On 12/18/20 6:25 AM, hejingxian wrote:
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index 26956c0..73af2f0 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -560,3 +560,10 @@ config RANDOM_TRUST_BOOTLOADER
> booloader is trustworthy so it will be added to the kernel's entropy
> pool. Otherwise, say N here so it will be regarded as device input that
> only mixes the entropy pool.
> +
> +config PIN_MEMORY_DEV
> + bool "/dev/pinmem character device"
> + depends PIN_MEMORY

depends on

> + default n

Don't need default n, it's already the default.

> + help
> + pin memory driver

Better help text, please. Also, it should be indented by 2 (more) spaces.


thanks.
--
~Randy