Re: [PATCH] mm/vmscan: DRY cleanup for do_try_to_free_pages()

[Jacob Wen]

On 12/19/20 9:21 AM, Chris Down wrote:
> Jacob Wen writes:
> > set_task_reclaim_state() is a function with 3 lines of code of which 
> > 2 lines contain WARN_ON_ONCE.
> >
> > I am not comfortable with the current repetition.
>
> Ok, but could you please go into _why_ others should feel that way 
> too? There are equally also reasons to err on the side of leaving code 
> as-is -- since we know it already works, and this code generally has 
> pretty high inertia -- and avoid mutation of code without concrete 
> description of the benefits.

I don't get your point. The patch doesn't change code of 
set_task_reclaim_state(), so I am fine with the repeated WARN_ON_ONCE.

I mean I prefer removing duplicate code to avoid going down the rabbit 
hole of set_task_reclaim_state().

It's a fundamental principle to me to move the code into its own 
function. I'd like to hear the others' opinions.