RE: [EXT] Re: [PATCH net v3] net: mvpp2: Fix GoP port 3 Networking Complex Control configurations

From: Stefan Chulski
Date: Sun Dec 20 2020 - 05:56:49 EST


> External Email
>
> ----------------------------------------------------------------------
> On Thu, 17 Dec 2020 14:37:28 +0200 stefanc@xxxxxxxxxxx wrote:
> > From: Stefan Chulski <stefanc@xxxxxxxxxxx>
> >
> > During GoP port 2 Networking Complex Control mode of operation
> > configurations, also GoP port 3 mode of operation was wrongly set.
> > Patch removes these configurations.
> > GENCONF_CTRL0_PORTX naming also fixed.
>
> Testing the stable backport it looks like this addition change will be
> problematic. Not to mention it goes against the "fixes should be minimal" rule.
>
> Could you please send just a one liner which removes the offending ORing in
> of the bad bit?
>
> We can do the rename soon after in net-next, the trees are merged pretty
> much every week so it won't be a long wait.

I would repost with single line change.

Regards,
Stefan.