Re: [PATCH] epoll: fix compat syscall wire up of epoll_pwait2

[Willem de Bruijn]

On Sun, Dec 20, 2020 at 6:43 AM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>
> On Sun, Dec 20, 2020 at 11:00 AM Heiko Carstens <hca@xxxxxxxxxxxxx> wrote:
> >
> > Commit b0a0c2615f6f ("epoll: wire up syscall epoll_pwait2") wired up
> > the 64 bit syscall instead of the compat variant in a couple of places.
> >
> > Cc: Willem de Bruijn <willemb@xxxxxxxxxx>
> > Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> > Cc: Arnd Bergmann <arnd@xxxxxxxx>
> > Cc: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> > Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> > Cc: Will Deacon <will@xxxxxxxxxx>
> > Cc: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>
> > Cc: Vasily Gorbik <gor@xxxxxxxxxxxxx>
> > Cc: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> > Fixes: b0a0c2615f6f ("epoll: wire up syscall epoll_pwait2")
> > Signed-off-by: Heiko Carstens <hca@xxxxxxxxxxxxx>
> > ---
> >  arch/arm64/include/asm/unistd32.h         | 2 +-
> >  arch/mips/kernel/syscalls/syscall_n32.tbl | 2 +-
> >  arch/s390/kernel/syscalls/syscall.tbl     | 2 +-
> >  arch/sparc/kernel/syscalls/syscall.tbl    | 2 +-
> >  4 files changed, 4 insertions(+), 4 deletions(-)
>
> I double-checked all the entries to make sure you caught all
> the missing ones, looks good.
>
> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>

Acked-by: Willem de Bruijn <willemb@xxxxxxxxxx>

Thanks a lot. I also arrived at the same list after comparing to
epoll_pwait and signalfd (for sigset) and ppoll_time64 (for timespec64).

Slightly tangential, it's not immediately clear to me why in
arch/x86/entry/syscalls/syscall_32.tbl epoll_pwait does not need a
compat entry, unlike on other architectures and unlike signalfd.