RE: Re: [PATCH v16 1/3] scsi: ufs: Introduce HPB feature

From: Daejun Park
Date: Sun Dec 20 2020 - 21:41:07 EST


Hi Greg,

> > +static void ufshpb_hpb_lu_prepared(struct ufs_hba *hba)
> > +{
> > + struct ufshpb_lu *hpb;
> > + struct scsi_device *sdev;
> > + bool init_success;
> > +
> > + init_success = !ufshpb_check_hpb_reset_query(hba);
> > +
> > + shost_for_each_device(sdev, hba->host) {
> > + hpb = sdev->hostdata;
> > + if (!hpb)
> > + continue;
> > +
> > + if (init_success) {
> > + dev_info(hba->dev, "set state to present\n");
>
> Why be noisy? Why does userspace need to see this all the time,
> shouldn't only errors be printing something?

I will remove needless dev_info printings in this patch.

Thanks,
Daejun