Re: [PATCH 2/4] KVM: x86/mmu: Get root level from walkers when retrieving MMIO SPTE

[Paolo Bonzini]

On 18/12/20 10:10, Vitaly Kuznetsov wrote:
> > -	int root = vcpu->arch.mmu->shadow_root_level;
> > -	int leaf;
> > -	int level;
> > +	int root, leaf, level;
> >   	bool reserved = false;
> Personal taste: I would've renamed 'root' to 'root_level' (to be
> consistent with get_walk()/kvm_tdp_mmu_get_walk()) and 'level' to
> e.g. 'l' as it's only being used as an interator ('i' would also do).

Maybe agree on the former, not really on the latter. :)

Paolo