Re: [PATCH 2/3] dt-bindings: atmel-sysreg: add microchip,sama7g5-shdwc

[Rob Herring]

On Wed, Dec 16, 2020 at 02:41:00PM +0100, Alexandre Belloni wrote:
> On 16/12/2020 14:57:32+0200, Claudiu Beznea wrote:
> > Add compatible for Microchip SAMA7G5's shutdown controller.
> > 
> > Signed-off-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/arm/atmel-sysregs.txt | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> I'm pretty sure the first comment you'll get is to convert this file to
> yaml ;)

I certainly wouldn't object, but just for a new compatible not requiring 
that (yet).

> > diff --git a/Documentation/devicetree/bindings/arm/atmel-sysregs.txt b/Documentation/devicetree/bindings/arm/atmel-sysregs.txt
> > index 62cd4e89817c..7990358ac06e 100644
> > --- a/Documentation/devicetree/bindings/arm/atmel-sysregs.txt
> > +++ b/Documentation/devicetree/bindings/arm/atmel-sysregs.txt
> > @@ -91,7 +91,8 @@ SHDWC SAMA5D2-Compatible Shutdown Controller
> >  1) shdwc node
> >  
> >  required properties:
> > -- compatible: should be "atmel,sama5d2-shdwc" or "microchip,sam9x60-shdwc".
> > +- compatible: should be "atmel,sama5d2-shdwc", "microchip,sam9x60-shdwc" or
> > +  "microchip,sama7g5-shdwc"
> >  - reg: should contain registers location and length
> >  - clocks: phandle to input clock.
> >  - #address-cells: should be one. The cell is the wake-up input index.
> > @@ -103,7 +104,7 @@ optional properties:
> >    microseconds. It's usually a board-related property.
> >  - atmel,wakeup-rtc-timer: boolean to enable Real-Time Clock wake-up.
> >  
> > -optional microchip,sam9x60-shdwc properties:
> > +optional microchip,sam9x60-shdwc or microchip,sama7g5-shdwc properties:
> >  - atmel,wakeup-rtt-timer: boolean to enable Real-time Timer Wake-up.
> >  
> >  The node contains child nodes for each wake-up input that the platform uses.
> > -- 
> > 2.7.4
> > 
> 
> -- 
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com