Re: [PATCH v3 05/24] wfx: add main.c/main.h

[Kalle Valo]

Jerome Pouiller <Jerome.Pouiller@xxxxxxxxxx> writes:

> +/* NOTE: wfx_send_pds() destroy buf */
> +int wfx_send_pds(struct wfx_dev *wdev, u8 *buf, size_t len)
> +{
> +	int ret;
> +	int start, brace_level, i;
> +
> +	start = 0;
> +	brace_level = 0;
> +	if (buf[0] != '{') {
> + dev_err(wdev->dev, "valid PDS start with '{'. Did you forget to
> compress it?\n");
> +		return -EINVAL;
> +	}
> +	for (i = 1; i < len - 1; i++) {
> +		if (buf[i] == '{')
> +			brace_level++;
> +		if (buf[i] == '}')
> +			brace_level--;
> +		if (buf[i] == '}' && !brace_level) {
> +			i++;
> +			if (i - start + 1 > WFX_PDS_MAX_SIZE)
> +				return -EFBIG;
> +			buf[start] = '{';
> +			buf[i] = 0;
> +			dev_dbg(wdev->dev, "send PDS '%s}'\n", buf + start);
> +			buf[i] = '}';
> +			ret = hif_configuration(wdev, buf + start,
> +						i - start + 1);
> +			if (ret > 0) {
> + dev_err(wdev->dev, "PDS bytes %d to %d: invalid data (unsupported
> options?)\n",
> +					start, i);
> +				return -EINVAL;
> +			}
> +			if (ret == -ETIMEDOUT) {
> + dev_err(wdev->dev, "PDS bytes %d to %d: chip didn't reply (corrupted
> file?)\n",
> +					start, i);
> +				return ret;
> +			}
> +			if (ret) {
> + dev_err(wdev->dev, "PDS bytes %d to %d: chip returned an unknown
> error\n",
> +					start, i);
> +				return -EIO;
> +			}
> +			buf[i] = ',';
> +			start = i;
> +		}
> +	}
> +	return 0;
> +}

What does this function do? Looks very strange.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches