Re: [PATCH net] net: ipa: fix interconnect enable bug

[Georgi Djakov]

On 12/22/20 17:16, Alex Elder wrote:
> When the core clock rate and interconnect bandwidth specifications
> were moved into configuration data, a copy/paste bug was introduced,
> causing the memory interconnect bandwidth to be set three times
> rather than enabling the three different interconnects.
>
> Fix this bug.
>
> Fixes: 91d02f9551501 ("net: ipa: use config data for clocking")
> Signed-off-by: Alex Elder <elder@xxxxxxxxxx>

Reviewed-by: Georgi Djakov <georgi.djakov@xxxxxxxxxx>

> ---
>   drivers/net/ipa/ipa_clock.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ipa/ipa_clock.c b/drivers/net/ipa/ipa_clock.c
> index 9dcf16f399b7a..135c393437f12 100644
> --- a/drivers/net/ipa/ipa_clock.c
> +++ b/drivers/net/ipa/ipa_clock.c
> @@ -115,13 +115,13 @@ static int ipa_interconnect_enable(struct ipa *ipa)
>   		return ret;
>   
>   	data = &clock->interconnect_data[IPA_INTERCONNECT_IMEM];
> -	ret = icc_set_bw(clock->memory_path, data->average_rate,
> +	ret = icc_set_bw(clock->imem_path, data->average_rate,
>   			 data->peak_rate);
>   	if (ret)
>   		goto err_memory_path_disable;
>   
>   	data = &clock->interconnect_data[IPA_INTERCONNECT_CONFIG];
> -	ret = icc_set_bw(clock->memory_path, data->average_rate,
> +	ret = icc_set_bw(clock->config_path, data->average_rate,
>   			 data->peak_rate);
>   	if (ret)
>   		goto err_imem_path_disable;