Re: [PATCH v2 44/48] ARM: tegra: Add OPP tables and power domains to Tegra30 device-tree

[Dmitry Osipenko]

22.12.2020 12:14, Viresh Kumar пишет:
> On 17-12-20, 21:06, Dmitry Osipenko wrote:
>> diff --git a/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi b/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi
>> index cbe84d25e726..983db1a06682 100644
>> --- a/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi
>> +++ b/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi
>> @@ -1,6 +1,56 @@
>>  // SPDX-License-Identifier: GPL-2.0
>>  
>>  / {
>> +	core_opp_table: core-power-domain-opp-table {
>> +		compatible = "operating-points-v2";
>> +		opp-shared;
>> +
>> +		core_opp_950: opp@950000 {
>> +			opp-microvolt = <950000 950000 1350000>;
>> +			opp-level = <950000>;
> 
> Perhaps you don't need to exactly copy the voltage value into the level field.
> The level field can just be kept to 0, 1,2, 3, etc..

It's much more convenient to set both fields to the same value because
the level values are shown in GENPD debugfs and the 0,1,2 values are
meaningless from the debugging perspective.