Re: [External] Re: [PATCH v11 10/11] mm/hugetlb: Gather discrete indexes of tail page

[Muchun Song]

On Wed, Dec 23, 2020 at 12:30 AM Oscar Salvador <osalvador@xxxxxxx> wrote:
>
> On Tue, Dec 22, 2020 at 10:24:39PM +0800, Muchun Song wrote:
> > +#else
> > +static inline void hwpoison_subpage_deliver(struct hstate *h, struct page *head)
> > +{
> > +}
> > +
> > +static inline void hwpoison_subpage_set(struct hstate *h, struct page *head,
> > +                                     struct page *page)
> > +{
> > +     if (PageHWPoison(head) && page != head) {
> > +             /*
> > +              * Move PageHWPoison flag from head page to the raw error page,
> > +              * which makes any subpages rather than the error page reusable.
> > +              */
> > +             SetPageHWPoison(page);
> > +             ClearPageHWPoison(head);
> > +     }
> > +}
> > +#endif
>
> Sorry, I guess I should have made a more clear statement.
> This patch should really be about changing the numeric index to its symbolic
> names, so the #ifdef handling of hwpoison_subpage_* should have been gone into
> patch#6.

Because patch#6 is also compatible with !CONFIG_HUGETLB_PAGE_FREE_VMEMMAP.
So I add the #ifdef handling in this patch. But moving it to patch#6
also makes sense to me. Thanks.

>
> I will have a closer look later on though.

Thanks.

>
> --
> Oscar Salvador
> SUSE L3



-- 
Yours,
Muchun