Re: [External] Re: [PATCH v11 03/11] mm/hugetlb: Free the vmemmap pages associated with each HugeTLB page

[Muchun Song]

On Wed, Dec 23, 2020 at 12:32 AM Oscar Salvador <osalvador@xxxxxxx> wrote:
>
> On Tue, Dec 22, 2020 at 10:24:32PM +0800, Muchun Song wrote:
> > diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
> > index 5d0767cb424a..eff5b13a6945 100644
> > --- a/include/linux/mmdebug.h
> > +++ b/include/linux/mmdebug.h
> > @@ -37,6 +37,13 @@ void dump_mm(const struct mm_struct *mm);
> >                       BUG();                                          \
> >               }                                                       \
> >       } while (0)
> > +#define VM_WARN_ON_PAGE(cond, page)                                  \
> > +     do {                                                            \
> > +             if (unlikely(cond)) {                                   \
> > +                     dump_page(page, "VM_WARN_ON_PAGE(" __stringify(cond)")");\
> > +                     WARN_ON(1);                                     \
> > +             }                                                       \
> > +     } while (0)
> >  #define VM_WARN_ON_ONCE_PAGE(cond, page)     ({                      \
> >       static bool __section(".data.once") __warned;                   \
> >       int __ret_warn_once = !!(cond);                                 \
> > @@ -60,6 +67,7 @@ void dump_mm(const struct mm_struct *mm);
> >  #define VM_BUG_ON_MM(cond, mm) VM_BUG_ON(cond)
> >  #define VM_WARN_ON(cond) BUILD_BUG_ON_INVALID(cond)
> >  #define VM_WARN_ON_ONCE(cond) BUILD_BUG_ON_INVALID(cond)
> > +#define VM_WARN_ON_PAGE(cond, page) BUILD_BUG_ON_INVALID(cond)
> >  #define VM_WARN_ON_ONCE_PAGE(cond, page)  BUILD_BUG_ON_INVALID(cond)
> >  #define VM_WARN_ONCE(cond, format...) BUILD_BUG_ON_INVALID(cond)
> >  #define VM_WARN(cond, format...) BUILD_BUG_ON_INVALID(cond)
>
> Take this off this patch and make it a preparation patch prior to this one.
> A new VM_WARN_ON_ macro does not make much sense in this patch as it is
> not related.

OK. Will do in the next version. Thanks.

>
> I will have a look later today at the other changes, but so far looks good.
>
> --
> Oscar Salvador
> SUSE L3



-- 
Yours,
Muchun