Re: [PATCH v3 1/7] iommu: Move iotlb_sync_map out from __iommu_map

From: Christoph Hellwig
Date: Wed Dec 23 2020 - 03:52:49 EST


On Wed, Dec 16, 2020 at 06:36:01PM +0800, Yong Wu wrote:
> In the end of __iommu_map, It alway call iotlb_sync_map.
> This patch moves iotlb_sync_map out from __iommu_map since it is
> unnecessary to call this for each sg segment especially iotlb_sync_map
> is flush tlb all currently.
>
> Signed-off-by: Yong Wu <yong.wu@xxxxxxxxxxxx>
> Reviewed-by: Robin Murphy <robin.murphy@xxxxxxx>

What about adding a little helper that does the NULL check and method
call instead of duplicating it all over?