Re: [PATCH] blokc/blk-merge: remove the next_bvec label in __blk_bios_map_sg()linux-block@xxxxxxxxxxxxxxx (open list:BLOCK LAYER)
From: Hui Su
Date: Wed Dec 23 2020 - 06:01:43 EST
On Wed, Dec 23, 2020 at 08:33:07AM +0000, Christoph Hellwig wrote:
> On Wed, Dec 23, 2020 at 12:31:58PM +0800, sh wrote:
> > remove the next_bvec label in __blk_bios_map_sg(), simplify the logic
> > of traversal bvec.
>
> What makes you believe that this simplifies anything?
1. this change remove the jump lable, so we do not need goto.
2. we do not need to assign flase to new_bio in the
bio_for_each_bvec, we only need to assign false to new_bio at first.
And I have resend a PATCH V2, this change have some format problem.
Thanks.