Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

[Andrew Lunn]

On Wed, Dec 23, 2020 at 12:32:18PM -0800, Jakub Kicinski wrote:
> On Wed, 23 Dec 2020 16:33:04 +0100 Andrew Lunn wrote:
> > On Wed, Dec 23, 2020 at 07:06:12PM +0800, Dinghao Liu wrote:
> > > When mdiobus_register() fails, priv->mdio allocated
> > > by mdiobus_alloc() has not been freed, which leads
> > > to memleak.
> > > 
> > > Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx>  
> > 
> > Fixes: bfa49cfc5262 ("net/ethoc: fix null dereference on error exit path")
> > 
> > Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
> 
> Ooof, I applied without looking at your email and I added:
> 
> Fixes: e7f4dc3536a4 ("mdio: Move allocation of interrupts into core")

[Goes and looks deeper]

Yes, commit e7f4dc3536a4 looks like it introduced the original
problem. bfa49cfc5262 just moved to code around a bit.

Does patchwork not automagically add Fixes: lines from full up emails?
That seems like a reasonable automation.

	 Andrew