Re: [PATCH] net: ena: remove h from printk format specifier

[Jakub Kicinski]

On Wed, 23 Dec 2020 11:31:44 -0800 trix@xxxxxxxxxx wrote:
> From: Tom Rix <trix@xxxxxxxxxx>
> 
> This change fixes the checkpatch warning described in this commit
> commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]")
> 
> Standard integer promotion is already done and %hx and %hhx is useless
> so do not encourage the use of %hh[xudi] or %h[xudi].
> 
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>

This really is not a change worth making in existing code, IMO.

I find it a little ironic that nacking of unnecessary code churn has
spawned unnecessary code churn in the opposite direction.

I'd leave it up to maintainers of specific drivers to decide, but for
now - net-next is closed anyway, please come back with these after
merge window is over.

Thanks!