RE: [PATCH v1] scsi: ufs-mediatek: Enable UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL

[Avri Altman]

Hi,
Just to clarify things:

> > Do you see any substantial benefit of having fWriteBoosterBufferFlushEn
> > disabled?
> 
> 1. The definition of fWriteBoosterBufferFlushEn is that host allows
> device to do flush in anytime after fWriteBoosterBufferFlushEn is set as
> on. This is not what we want.
> 
> Just Like BKOP, We do not want flush happening beyond host's expected
> timing that device performance may be "randomly" dropped.
Explicit flush takes place only when the device is idle:
if fWriteBoosterBufferFlushEn is set, the device is idle, and before h8 received.
If a request arrives, the flush operation should be halted.
So no performance degradation is expected. 

> 
> 2. Another related concern is that currently fWriteBoosterBufferFlushEn
> may keep on while device is not in Active Power Mode during suspend
> period. I am not sure if such configuration would confuse the device.
The spec says: " While the flushing operation is in progress, the device is in Active power mode"

> 
> Thanks,
> Stanley Chu
> 
> >
> > Thanks,
> > Can Guo.
> >
> > >
> > > Thanks,
> > >
> > > Can Guo.
> > >
> > >> Thanks,
> > >> Stanley Chu
> > >>>
> > >>> Change LGTM.
> > >>>
> > >>> Regards,
> > >>>
> > >>> Can Guo.