Re: [v6,1/3] dt-binding: reset-controller: mediatek: add YAML schemas
From: Crystal Guo
Date: Sat Dec 26 2020 - 04:14:34 EST
On Thu, 2020-12-03 at 15:41 +0800, Philipp Zabel wrote:
> Hi,
>
> On Wed, 2020-09-30 at 10:21 +0800, Crystal Guo wrote:
> > Add a YAML documentation for Mediatek, which uses ti reset-controller
> > driver directly. The TI reset controller provides a common reset
> > management, and is suitable for Mediatek SoCs.
> >
> > Signed-off-by: Crystal Guo <crystal.guo@xxxxxxxxxxxx>
> > ---
> > .../bindings/reset/mediatek-syscon-reset.yaml | 51 +++++++++++++++++++
> > 1 file changed, 51 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml b/Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml
> > new file mode 100644
> > index 000000000000..7871550c3c69
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml
> > @@ -0,0 +1,51 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/reset/mediatek-syscon-reset.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Mediatek Reset Controller
> > +
> > +maintainers:
> > + - Crystal Guo <crystal.guo@xxxxxxxxxxxx>
> > +
> > +description:
> > + The bindings describe the reset-controller for Mediatek SoCs,
> > + which is based on TI reset controller. For more detail, please
> > + visit Documentation/devicetree/bindings/reset/ti-syscon-reset.txt.
> > +
> > +properties:
> > + compatible:
> > + const: mediatek,syscon-reset
> > +
> > + '#reset-cells':
> > + const: 1
> > +
> > + mediatek,reset-bits:
> > + description: >
> > + Contains the reset control register information, please refer to
> > + Documentation/devicetree/bindings/reset/ti-syscon-reset.txt.
>
> I would really like some input from Rob on this, in v4 he asked not to
> repeat 'ti,reset-bits'.
>
> regards
> Philipp
Hi Rob,
Can you give some suggestions on this document
"mediatek-syscon-reset.yaml", many thanks~
regards
Crystal Guo