Re: [PATCH v3 13/14] include: media: v4l2-fwnode: Include v4l2_fwnode_bus_type

[Daniel Scally]

Hi Andy

On 24/12/2020 12:32, Andy Shevchenko wrote:
> On Thu, Dec 24, 2020 at 3:13 AM Daniel Scally <djrscally@xxxxxxxxx> wrote:

> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

Thank you

>> +/**
>> + * enum v4l2_fwnode_bus_type - Video bus types defined by firmware properties
>> + * @V4L2_FWNODE_BUS_TYPE_GUESS: Default value if no bus-type fwnode property
>> + * @V4L2_FWNODE_BUS_TYPE_CSI2_CPHY: MIPI CSI-2 bus, C-PHY physical layer
>> + * @V4L2_FWNODE_BUS_TYPE_CSI1: MIPI CSI-1 bus
>> + * @V4L2_FWNODE_BUS_TYPE_CCP2: SMIA Compact Camera Port 2 bus
>> + * @V4L2_FWNODE_BUS_TYPE_CSI2_DPHY: MIPI CSI-2 bus, D-PHY physical layer
>> + * @V4L2_FWNODE_BUS_TYPE_PARALLEL: Camera Parallel Interface bus
>> + * @V4L2_FWNODE_BUS_TYPE_BT656: BT656 video format bus-type
>> + * @NR_OF_V4L2_FWNODE_BUS_TYPE: Number of bus-types
>> + */
>> +enum v4l2_fwnode_bus_type {
>> +       V4L2_FWNODE_BUS_TYPE_GUESS = 0,
>> +       V4L2_FWNODE_BUS_TYPE_CSI2_CPHY,
>> +       V4L2_FWNODE_BUS_TYPE_CSI1,
>> +       V4L2_FWNODE_BUS_TYPE_CCP2,
>> +       V4L2_FWNODE_BUS_TYPE_CSI2_DPHY,
>> +       V4L2_FWNODE_BUS_TYPE_PARALLEL,
>> +       V4L2_FWNODE_BUS_TYPE_BT656,
> 
>> +       NR_OF_V4L2_FWNODE_BUS_TYPE,
> 
> I see that comma is in the original line, but I think it's a good time
> to remove it from this line. Since it's a terminator line we might
> prevent potential issues during review (by a different diff look) and
> at compile time (if anything comes after it).

Fair enough, I've removed it.