Re: [PATCH] net/mlx5e: Fix memleak in mlx5e_create_l2_table_groups

From: Leon Romanovsky
Date: Sun Dec 27 2020 - 03:36:05 EST


On Mon, Dec 21, 2020 at 07:27:31PM +0800, Dinghao Liu wrote:
> When mlx5_create_flow_group() fails, ft->g should be
> freed just like when kvzalloc() fails. The caller of
> mlx5e_create_l2_table_groups() does not catch this
> issue on failure, which leads to memleak.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_fs.c | 1 +
> 1 file changed, 1 insertion(+)
>

Fixes: 33cfaaa8f36f ("net/mlx5e: Split the main flow steering table")

Thanks,
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>