Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE

From: Vijayanand Jitta
Date: Sun Dec 27 2020 - 23:56:54 EST




On 12/23/2020 8:10 PM, Alexander Potapenko wrote:
>>
>> Michan, We would still need config option so that we can reduce the
>> memory consumption on low ram devices using config.
>>
>> Alex, On this,
>> "I also suppose device vendors may prefer setting a fixed (maybe
>> non-default) hash size for low-memory devices rather than letting the
>> admins increase it."
>> I see kernel param swiotlb does similar thing i.e; '0' to disable and
>> set a value to configure size.
>>
>> I am fine with either of the approaches,
>>
>> 1. I can split this patch into two
>> i) A bool variable to enable/disable stack depot.
>> ii) A config for the size.
>
> I still believe this is a more appropriate solution.
>
> Thanks in advance!
>

Thanks, Will work on a patch with above approach.

Thanks,
Vijay
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of Code Aurora Forum, hosted by The Linux Foundation