RE: [PATCH] scsi: qedi: add printf attribute to log function

[Manish Rangankar]

> -----Original Message-----
> From: trix@xxxxxxxxxx <trix@xxxxxxxxxx>
> Sent: Monday, December 21, 2020 9:54 PM
> To: Nilesh Javali <njavali@xxxxxxxxxxx>; Manish Rangankar
> <mrangankar@xxxxxxxxxxx>; jejb@xxxxxxxxxxxxx;
> martin.petersen@xxxxxxxxxx
> Cc: GR-QLogic-Storage-Upstream <GR-QLogic-Storage-
> Upstream@xxxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Tom Rix <trix@xxxxxxxxxx>
> Subject: [PATCH] scsi: qedi: add printf attribute to log function
> 
> From: Tom Rix <trix@xxxxxxxxxx>
> 
> Attributing the function allows the compiler to more thoroughly check the
> use of the function with -Wformat and similar flags.
> 
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
> ---
>  drivers/scsi/qedi/qedi_dbg.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qedi/qedi_dbg.h b/drivers/scsi/qedi/qedi_dbg.h
> index 37d084086fd4..b2c9b0a2db6a 100644
> --- a/drivers/scsi/qedi/qedi_dbg.h
> +++ b/drivers/scsi/qedi/qedi_dbg.h
> @@ -78,13 +78,16 @@ struct qedi_dbg_ctx {
>  #define QEDI_INFO(pdev, level, fmt, ...)	\
>  		qedi_dbg_info(pdev, __func__, __LINE__, level, fmt,	\
>  			      ## __VA_ARGS__)
> -
> +__printf(4, 5)
>  void qedi_dbg_err(struct qedi_dbg_ctx *qedi, const char *func, u32 line,
>  		  const char *fmt, ...);
> +__printf(4, 5)
>  void qedi_dbg_warn(struct qedi_dbg_ctx *qedi, const char *func, u32 line,
>  		   const char *fmt, ...);
> +__printf(4, 5)
>  void qedi_dbg_notice(struct qedi_dbg_ctx *qedi, const char *func, u32
> line,
>  		     const char *fmt, ...);
> +__printf(5, 6)
>  void qedi_dbg_info(struct qedi_dbg_ctx *qedi, const char *func, u32 line,
>  		   u32 info, const char *fmt, ...);
> 

Thanks,
Acked-by: Manish Rangankar <mrangankar@xxxxxxxxxxx>