Re: [PATCH v1 1/2] dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting

[Laurent Pinchart]

Hi Xin Ji,

Thank you for the patch.

On Fri, Dec 25, 2020 at 07:01:09PM +0800, Xin Ji wrote:
> Add DPI flag for distinguish MIPI input signal type, DSI or DPI. Add
> swing setting for adjusting DP tx PHY swing
> 
> Signed-off-by: Xin Ji <xji@xxxxxxxxxxxxxxxx>
> ---
>  .../bindings/display/bridge/analogix,anx7625.yaml     | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index 60585a4..34a7faf 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -34,6 +34,14 @@ properties:
>      description: used for reset chip control, RESET_N pin B7.
>      maxItems: 1
>  
> +  anx,swing-setting:
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    description: an array of swing register setting for DP tx PHY

Register values in DT are frowned upon.

> +  anx,mipi-dpi-in:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: indicate the MIPI rx signal type is DPI or DSI

This sounds similar to the bus-type property defined in
Documentation/devicetree/bindings/media/video-interfaces.txt (which is
getting converted to YAML, Rob has posted a patch series, I expect it to
land in v5.13). I think it would make sense to extend bus-type to
support DSI, and use that property.

> +
>    ports:
>      type: object
>  
> @@ -72,6 +80,17 @@ examples:
>              reg = <0x58>;
>              enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>;
>              reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;
> +            anx,swing-setting = <0x00 0x14>, <0x01 0x54>,
> +                <0x02 0x64>, <0x03 0x74>, <0x04 0x29>,
> +                <0x05 0x7b>, <0x06 0x77>, <0x07 0x5b>,
> +                <0x08 0x7f>, <0x0c 0x20>, <0x0d 0x60>,
> +                <0x10 0x60>, <0x12 0x40>, <0x13 0x60>,
> +                <0x14 0x14>, <0x15 0x54>, <0x16 0x64>,
> +                <0x17 0x74>, <0x18 0x29>, <0x19 0x7b>,
> +                <0x1a 0x77>, <0x1b 0x5b>, <0x1c 0x7f>,
> +                <0x20 0x20>, <0x21 0x60>, <0x24 0x60>,
> +                <0x26 0x40>, <0x27 0x60>;
> +            anx,mipi-dpi-in = <0>;
>  
>              ports {
>                  #address-cells = <1>;

-- 
Regards,

Laurent Pinchart