Re: [PATCH 1/2] dt-bindings: arm: fsl: Add binding for Gateworks boards with IMX8MM

[Tim Harvey]

On Thu, Dec 24, 2020 at 3:23 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On Wed, Dec 23, 2020 at 02:23:15PM -0800, Tim Harvey wrote:
> > Add bindings for the Gateworks Venice Development kit boards with
> > IMX8MM System on Module.
> >
> > Signed-off-by: Tim Harvey <tharvey@xxxxxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 1ca9dfa..705c6e8 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -405,6 +405,9 @@ properties:
> >                - beacon,imx8mm-beacon-kit  # i.MX8MM Beacon Development Kit
> >                - fsl,imx8mm-ddr4-evk       # i.MX8MM DDR4 EVK Board
> >                - fsl,imx8mm-evk            # i.MX8MM EVK Board
> > +              - gw,imx8mm-gw71xx-0x       # i.MX8MM Gateworks Development Kit
> > +              - gw,imx8mm-gw72xx-0x       # i.MX8MM Gateworks Development Kit
> > +              - gw,imx8mm-gw73xx-0x       # i.MX8MM Gateworks Development Kit
>
> I think you should skip the wildcards in compatible and choose one
> specific compatible. What if at some point you would like to add gw,imx8mm-gw7113-0x?
>

Krzysztof,

Thanks for the review. I do want the wildcards as above because they
represent model variations that do not affect device-tree such as
component subloads.

Thanks,

Tim