Re: [git pull] drm fixes for 5.11-rc1

[Rodrigo Siqueira]

Hi,

This patch should fix the issue:

 https://patchwork.freedesktop.org/patch/410754/?series=85303&rev=1

Thanks

On 12/29, R, Bindu wrote:
>    [AMD Official Use Only - Internal Distribution Only]
> 
>    ++Siqueira.
>    Regards,
>    Bindu
> 
>    ══════════════════════════════════════════════════════════════════════════
> 
>    From: Alex Deucher <alexdeucher@xxxxxxxxx>
>    Sent: Tuesday, December 29, 2020 10:07 AM
>    To: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>; Wentland, Harry
>    <Harry.Wentland@xxxxxxx>; Kazlauskas, Nicholas
>    <Nicholas.Kazlauskas@xxxxxxx>; Wu, Hersen <hersenxs.wu@xxxxxxx>
>    Cc: Dave Airlie <airlied@xxxxxxxxx>; Pavic, Josip <Josip.Pavic@xxxxxxx>;
>    R, Bindu <Bindu.R@xxxxxxx>; Deucher, Alexander
>    <Alexander.Deucher@xxxxxxx>; Daniel Vetter <daniel.vetter@xxxxxxxx>; LKML
>    <linux-kernel@xxxxxxxxxxxxxxx>; dri-devel
>    <dri-devel@xxxxxxxxxxxxxxxxxxxxx>
>    Subject: Re: [git pull] drm fixes for 5.11-rc1
>     
>    On Thu, Dec 24, 2020 at 5:28 PM Linus Torvalds
>    <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>    >
>    > On Wed, Dec 23, 2020 at 6:29 PM Dave Airlie <airlied@xxxxxxxxx> wrote:
>    > >
>    > > Xmas eve pull request present. Just some fixes that trickled in this
>    > > past week. Mostly amdgpu fixes, with a dma-buf/mips build fix and some
>    > > misc komeda fixes.
>    >
>    > Well, I already pulled and pushed out my merge, but only noticed
>    > afterwards that clang complains about this, and I think it's a real
>    > bug:
>    >
>    >   drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_mpc.c:475:6:
>    warning:
>    >      variable 'val' is used uninitialized whenever 'if' condition is
>    > false [-Wsometimes-uninitialized]
>    >
>    > and it sure is true: the code literally does
>    >
>    >         uint32_t val;
>    >
>    >         if (opp_id < MAX_OPP && REG(MUX[opp_id]))
>    >                 REG_GET(MUX[opp_id], MPC_OUT_MUX, &val);
>    >
>    >         return val;
>    >
>    > so clearly 'val' isn't initialized if that if-statement isn't true.
>    >
>    > I assume 'opp_id' is always presumed to be valid, but that code really
>    > is disgusting.
>    >
>    > Just make it return 0 (or whatever) for invalid, possibly together
>    > with a WARN_ON_ONCE(). Ok?
> 
>    Harry, Nick, Hersen,
> 
>    Can you take a look?
> 
>    Thanks,
> 
>    Alex
> 
>    >
>    >              Linus
>    > _______________________________________________
>    > dri-devel mailing list
>    > dri-devel@xxxxxxxxxxxxxxxxxxxxx
>    >
>    [1]https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&amp;data=04%7C01%7Cbindu.r%40amd.com%7Cae8f547c9287426b9b9408d8ac0b7b73%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637448512618562550%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=4gcQRS3HI4u1UEWu35Ze1w5CLWmAof5nouCFQoKEQD0%3D&amp;reserved=0
> 
> References
> 
>    Visible links
>    1. https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&amp;data=04%7C01%7Cbindu.r%40amd.com%7Cae8f547c9287426b9b9408d8ac0b7b73%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637448512618562550%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=4gcQRS3HI4u1UEWu35Ze1w5CLWmAof5nouCFQoKEQD0%3D&amp;reserved=0

-- 
Rodrigo Siqueira
https://siqueira.tech

Attachment: signature.asc
Description: PGP signature