Re: [PATCH 3/4] usb: gadget: u_audio: remove struct uac_req
From: Jack Pham
Date: Tue Dec 29 2020 - 17:31:45 EST
Hi Greg and Jerome,
On Mon, Dec 28, 2020 at 04:01:46PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Dec 21, 2020 at 06:35:30PM +0100, Jerome Brunet wrote:
> > 'struct uac_req' purpose is to link 'struct usb_request' to the
> > corresponding 'struct uac_rtd_params'. However member req is never
> > used. Using the context of the usb request, we can keep track of the
> > corresponding 'struct uac_rtd_params' just as well, without allocating
> > extra memory.
> >
> > Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
> > ---
> > drivers/usb/gadget/function/u_audio.c | 58 ++++++++++++---------------
> > 1 file changed, 26 insertions(+), 32 deletions(-)
>
> This patch doesn't apply, so I can't apply patches 3 or 4 of this series
> :(
>
> Can you rebase against my usb-testing branch and resend?
>From the cover letter:
On Mon, Dec 21, 2020 at 06:35:27PM +0100, Jerome Brunet wrote:
> The series depends on this fix [0] by Jack Pham to apply cleanly
>
> [0]: https://lore.kernel.org/linux-usb/20201029175949.6052-1-jackp@xxxxxxxxxxxxxx/
My patch hadn't been picked up by Felipe, so it's not in your tree
either, Greg. Should I just resend it to you first? Or shall I invite
Jerome to just include it in v2 of this series?
Thanks,
Jack
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project