Re: [PATCH 07/21] vdpa: multiple address spaces support

[Eli Cohen]

On Wed, Dec 30, 2020 at 12:04:30PM +0800, Jason Wang wrote:
> 
> On 2020/12/29 下午3:28, Eli Cohen wrote:
> > > @@ -43,6 +43,8 @@ struct vdpa_vq_state {
> > >    * @index: device index
> > >    * @features_valid: were features initialized? for legacy guests
> > >    * @nvqs: the number of virtqueues
> > > + * @ngroups: the number of virtqueue groups
> > > + * @nas: the number of address spaces
> > I am not sure these can be categorised as part of the state of the VQ.
> > It's more of a property so maybe we can have a callback to get the
> > properties of the VQ?
> 
> 
> Or maybe there's a misunderstanding of the patch.
> 

Yes, I misinterpreted the hunk. No issue here.

> Those two attributes belongs to vdpa_device instead of vdpa_vq_state
> actually.
> 
> Thanks
>